Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: add config to only use checksum, skip select data #215

Merged
merged 5 commits into from
Apr 2, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

in some case, user only want to check data is equal or not, and don't want to know which row is not equal.

What is changed and how it works?

add a config only-use-checksum, if set to true, will skip select data when checksum is not equal.

Check List

Tests

  • Manual test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/diff/diff_test.go Outdated Show resolved Hide resolved
@IANTHEREAL
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants